Glebashnik/feed field generator #32842
Conversation
...glanguage/src/main/java/com/yahoo/vespa/indexinglanguage/expressions/GenerateExpression.java
Show resolved
Hide resolved
...glanguage/src/main/java/com/yahoo/vespa/indexinglanguage/expressions/GenerateExpression.java
Outdated
Show resolved
Hide resolved
...glanguage/src/main/java/com/yahoo/vespa/indexinglanguage/expressions/GenerateExpression.java
Outdated
Show resolved
Hide resolved
...glanguage/src/main/java/com/yahoo/vespa/indexinglanguage/expressions/GenerateExpression.java
Outdated
Show resolved
Hide resolved
...glanguage/src/main/java/com/yahoo/vespa/indexinglanguage/expressions/GenerateExpression.java
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,29 @@ | |||
| package ai.vespa.generative; | |||
There was a problem hiding this comment.
Same, I think we could put this in llm.generation
And maybe, since what separates it from Generator isn't that it's generating from a language model, but that it's taking an additional config specifying a prompt, we could call it something like PromptedGenerator, or ConfiguredGenerator?
linguistics/src/main/java/com/yahoo/language/process/Generator.java
Outdated
Show resolved
Hide resolved
| return Map.of(name, this); | ||
| } | ||
|
|
||
| String generate(String prompt, Context context, DataType dataType); |
There was a problem hiding this comment.
Why not use the Prompt class here so we have the option of passing prompts through that aren't just strings.
| @@ -31,7 +34,7 @@ | |||
| * | |||
| * @author lesters | |||
| */ | |||
| public class LocalLLM extends AbstractComponent implements LanguageModel { | |||
| public class LocalLLM extends AbstractComponent implements LanguageModel, Generator { | |||
There was a problem hiding this comment.
The role of Generator is to apply a LanguageModel to a generation task specified by a context. This is a more general API so it's a bit messy for it to know about that context (and also to call itself through a utility defined elsewhere). I see the purpose though ... maybe there's a better solution, but I need to get some breakfast now.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.