Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple LDAP Server Configurations Support #24

Merged
merged 1 commit into from
Feb 24, 2015
Merged

Conversation

farumi
Copy link

@farumi farumi commented Feb 23, 2015

Hello,

I need the functionality discussed on #13 . You finally didn't accept the change because was not backwards compatible. Wise desicion.

I've taken the liberty to redo this work, with the changes you were demanding:

  • The callback which returns the LDAP options is checked and called with 1 or 2 arguments to ensure backwards compatibility.
  • Existing tests pass and new tests are added to check the 2-argument trick.

Thank you very much for your work,
Ferran

…tatic configuration object, you can pass a function as options that will take care of fetching the configuration. It will be called with a callback function having the standard (err, result) signature. Notice that the provided function will be called on every authenticate request
@vesse vesse merged commit a72611d into vesse:master Feb 24, 2015
@japel
Copy link

japel commented Mar 5, 2015

Awesome! exactly what I was looking for! Thanks farumi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants