Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_PackNativeAssets should not use RuntimeIdentifiers unconditionally #55

Closed
alexrp opened this issue Jun 29, 2022 · 0 comments
Closed

_PackNativeAssets should not use RuntimeIdentifiers unconditionally #55

alexrp opened this issue Jun 29, 2022 · 0 comments
Labels
area: sdk Issues related to the MSBuild SDK.
Milestone
v4.2

Comments

@alexrp
Copy link
Member

alexrp commented Jun 29, 2022

zig-sdk/src/sdk/build/Vezel.Zig.Sdk.Pack.targets

Lines 43 to 45 in 034b922

<ItemGroup>
<_RuntimeIdentifiers Include="$(RuntimeIdentifiers)" />
</ItemGroup>

It is possible to have a project with just the singular RuntimeIdentifier set and no RuntimeIdentifiers at all. _PackNativeAssets should handle this case properly.
@alexrp alexrp added type: bug state: approved Enhancements and tasks that have been approved. area: sdk Issues related to the MSBuild SDK. labels Jun 29, 2022
@alexrp alexrp added this to the v4.0 milestone Jun 29, 2022
@alexrp alexrp self-assigned this Jun 29, 2022
@alexrp alexrp modified the milestones: v4.0, v4.1 Aug 4, 2023
@alexrp alexrp added state: confirmed Bugs that have been confirmed and are reproducible. and removed state: approved Enhancements and tasks that have been approved. labels Dec 29, 2023
@alexrp alexrp modified the milestones: v4.1, v4.2 Jan 2, 2024
@alexrp alexrp closed this as completed in 6a48e6c Jan 5, 2024
alexrp added a commit that referenced this issue Jan 5, 2024
@alexrp
Ensure that Pack behaves correctly when a RID is set by the user.
37fa602 
Closes #55.
@alexrp alexrp removed the state: confirmed Bugs that have been confirmed and are reproducible. label Jan 5, 2024
@alexrp alexrp mentioned this issue Jan 6, 2024
Closed
@alexrp alexrp removed their assignment Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: sdk Issues related to the MSBuild SDK.
Milestone
v4.2
Development

No branches or pull requests
1 participant
@alexrp