fix: Use actual reference report #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vezenovm
added a commit
to noir-lang/noir
that referenced
this pull request
Apr 23, 2024
…r report is fixed
5 tasks
|
We can merge this into the parent as we are referencing the commit on Noir anyway |
github-merge-queue bot
pushed a commit
to noir-lang/noir
that referenced
this pull request
Apr 23, 2024
) # Description ## Problem\* Further context can be found in #4878 ## Summary\* This PR updates the commit to reference vezenovm/noir-gates-diff#2 which actually checks the report on master. We need the preceding PR in order to fix the reference report to use the actual package names in `execution_success`. ## Additional Context ## Documentation\* Check one: - [ ] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [ ] I have tested the changes locally. - [ ] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a followup to noir-lang#3. noir-lang#3 added a fix and also fixed the corrupt report on master. This PR goes back to using the actual reference report that was corrupted on master.