-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable tests on i568 #792
Comments
Could I work on this issue? And also is there any way to run the 32-bit tests locally? |
Go ahead. You can use a virtualization system like virtualbox or you can operate at the bot: https://clad.readthedocs.io/en/latest/user/DevelopersDocumentation.html#debugging-github-runners |
I got most of the tests running at https://github.com/MihailMihov/clad/tree/fix-32bit-tests, but I'm not sure if that's the correct way to solve the issue. Aren't the tests becoming somewhat weaker and maybe they'll fail to catch some regressions? |
If you mean that out of a sudden clang starts thinking that the size of a size_t is an int on 64 bit platforms, that's highly unlikely. If that happens many more things around the world will break first. The tests that are expected to test clad won't get weaker, however, if the tests intended to test clang that'd be correct.
We could but that's much more handwork work when we need to change them. I'd not do that.
What are the related stack traces? |
In PR #782 we have enabled support of 32 bit platforms and we have disabled many failing tests. Most of the failures are due to the fact that
sizeof
returnsunsigned int
on 32 bit and the test reference files require adjustment of that type:// CHECK-NEXT: unsigned {{(int|long)}} _t2 = sizeof(double);
The text was updated successfully, but these errors were encountered: