Support multiple indices in clad::gradient calls #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetroZarytskyi
force-pushed
the
issue-46
branch
3 times, most recently
from
432e478
to
29b3883
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1029 +/- ##
==========================================
+ Coverage 94.10% 94.12% +0.01%
==========================================
Files 55 55
Lines 8225 8234 +9
==========================================
+ Hits 7740 7750 +10
+ Misses 485 484 -1
... and 1 file with indirect coverage changes
|
Currently, the user can provide a string as the second argument of ``clad::gradient`` to specify independent parameters as a list of comma-separated names. This commit allows users to specify indices alongside with names. e.g. ``` clad::gradient(fn, "0"); clad::gradient(fn, "1, z"); ... ``` Previously, it was possible to provide a single index as an integer literal. e.g. ``` clad::gradient(fn, 0); ``` Fixes vgvassilev#46.
PetroZarytskyi
force-pushed
the
issue-46
branch
from
29b3883
to
0f4fae0
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the user can provide a string as the second argument of
clad::gradientto specify independent parameters as a list of comma-separated names. This PR allows users to specify indices alongside with names. e.g.Previously, it was possible to provide a single index as an integer literal. e.g.
Fixes #46.