Add location information and improve clarity of diagnostics. #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvassilev
force-pushed
the
improve-diags
branch
from
9278055
to
6e10d25
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1031 +/- ##
==========================================
- Coverage 94.04% 94.04% -0.01%
==========================================
Files 55 55
Lines 8244 8240 -4
==========================================
- Hits 7753 7749 -4
Misses 491 491
|
|
clang-tidy review says "All clean, LGTM! 👍" |
This patch is a first step towards diagnostics refactoring in the context of non-differentiable propagators.
vgvassilev
force-pushed
the
improve-diags
branch
from
6e10d25
to
578731f
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is a first step towards diagnostics refactoring in the context of non-differentiable propagators.