Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for constant variables in Reverse mode AD #517

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

arora-vidushi
Copy link
Contributor

Closes #430

@vgvassilev
Copy link
Owner

If there is no particular reason to have the tests in two separate commits, let’s squash them. Otherwise looks good to me.

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #517 (31a571f) into master (e5e3074) will not change coverage.
The diff coverage is n/a.

❗ Current head 31a571f differs from pull request most recent head 1d15654. Consider uploading reports for the commit 1d15654 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #517   +/-   ##
=======================================
  Coverage   92.48%   92.48%           
=======================================
  Files          39       39           
  Lines        5577     5577           
=======================================
  Hits         5158     5158           
  Misses        419      419           

@arora-vidushi
Copy link
Contributor Author

Yes I have squashed the commits now.

Copy link
Owner

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgvassilev vgvassilev merged commit 0a5ded2 into vgvassilev:master Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Derived variables should never be const in Reverse Mode AD
2 participants