Add matrix class in clad

[vaithak]

This class will be used for adding support for arrays in vector mode.

[codecov]

Codecov Report

Merging #609 (4848d33) into master (ad2b804) will not change coverage.
The diff coverage is n/a.

❗ Current head 4848d33 differs from pull request most recent head c8e7b4e. Consider uploading reports for the commit c8e7b4e to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #609   +/-   ##
=======================================
  Coverage   93.73%   93.73%           
=======================================
  Files          41       41           
  Lines        5939     5939           
=======================================
  Hits         5567     5567           
  Misses        372      372           

[parth-07]

Overall looks good.

[vgvassilev]

Modulo minor comments this looks good to me! Let's address them and merge it.

[github-actions]

clang-tidy made some suggestions

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[github-actions]

clang-tidy made some suggestions

[vaithak]

I have removed the special handling of creating clad::arrays without copying and instead used array_ref in such cases because it was leading to more confusion.

[vgvassilev]

I have removed the special handling of creating clad::arrays without copying and instead used array_ref in such cases because it was leading to more confusion.

Agreed. I was about to ask that question in the review but was carried away...

Another generic thing to consider is that eventually we will need to add C support.

[vaithak]

Another generic thing to consider is that eventually we will need to add C support.

Can you elaborate on what you mean by adding C support?

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[vgvassilev]

Another generic thing to consider is that eventually we will need to add C support.

Can you elaborate on what you mean by adding C support?

Very soon clad should start supporting the C language. We should probably be thinking about that when implementing new features in clad.

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[vaithak]

Is this good to go, or are any changes required?

[vgvassilev]

LGTM!

[vgvassilev]

The bot failures are not due to this PR. However, we should really look into the bot failures...