Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmark comparison in ci #621

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Conversation

vaithak
Copy link
Collaborator

@vaithak vaithak commented Aug 23, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #621 (1cd77a2) into master (fcec295) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #621   +/-   ##
=======================================
  Coverage   93.83%   93.83%           
=======================================
  Files          41       41           
  Lines        6032     6032           
=======================================
  Hits         5660     5660           
  Misses        372      372           

@vaithak vaithak force-pushed the ci/benchmark branch 4 times, most recently from 0508586 to 4d3dc6d Compare August 23, 2023 11:59
Copy link
Owner

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM!

@vgvassilev vgvassilev merged commit 7108591 into vgvassilev:master Aug 24, 2023
75 checks passed
@vgvassilev
Copy link
Owner

@vaithak, looks like when it went in the master it failed with: https://github.com/vgvassilev/clad/actions/runs/5960281839/job/16167325061

@vaithak
Copy link
Collaborator Author

vaithak commented Aug 24, 2023

yup, I tried to ssh into tmate for that action, but it didn't allow me to, maybe because of access related to master branch.
Will try to ssh into a PR branch and see what's going wrong.

I have found the issue, but need to figure out why that happened.
The problem is that git rev-parse HEAD is outputting HEAD instead of the commit id inside the cmake process, this only happens when HEAD is in a detached state.

@vgvassilev
Copy link
Owner

If you tried to do ssh via the web browser it does not work for me either. If you ssh via the terminal you need to type ctrl+c to get to a prompt. I can restart the same build if you want to retry.

@vaithak
Copy link
Collaborator Author

vaithak commented Aug 24, 2023

I tried with terminal only, it gave me Permission denied (publickey) error.

@vgvassilev
Copy link
Owner

I logged in, could you retry?

@vaithak
Copy link
Collaborator Author

vaithak commented Aug 24, 2023

I logged in, could you retry

trying

@vaithak
Copy link
Collaborator Author

vaithak commented Aug 24, 2023

still got the same error of Permission denied (publickey).
I am able to access ssh -T git@github.com so there should be no error with the keys setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants