Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pointer arithmetic for array types #764

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

vaithak
Copy link
Collaborator

@vaithak vaithak commented Feb 15, 2024

required for workaround mentioned in #762

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d305002) 94.71% compared to head (8faca4f) 94.71%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #764   +/-   ##
=======================================
  Coverage   94.71%   94.71%           
=======================================
  Files          49       49           
  Lines        7342     7342           
=======================================
  Hits         6954     6954           
  Misses        388      388           

@parth-07
Copy link
Collaborator

parth-07 commented Feb 15, 2024

Thank you for the quick fix. However, if we don't need this urgently, then I think we should wait for #758. If I understand correctly, #758 should fix this issue as well, right?

Copy link
Collaborator

@parth-07 parth-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@vgvassilev vgvassilev merged commit 7de91af into vgvassilev:master Feb 15, 2024
81 checks passed
@vaithak vaithak deleted the ptr-arithmetic branch March 13, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants