Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify pullback calls in the reverse mode #802

Merged
merged 10 commits into from
Mar 18, 2024
Merged

Simplify pullback calls in the reverse mode #802

merged 10 commits into from
Mar 18, 2024

Commits on Mar 14, 2024

  1. Simplify pullback calls by replacing _grad/_r pairs with single _r va… 

    …riables and not storing pointer args
    @PetroZarytskyi
    PetroZarytskyi committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    b0dd506 View commit details
    Browse the repository at this point in the history

  2. Expect a SourceLocation assertion in ArrayInputsReverseMode.C

    @PetroZarytskyi
    PetroZarytskyi committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    76246b7 View commit details
    Browse the repository at this point in the history

  3. Don't expect a SourceLocation assertion in UserDefinedTypes.C

    @PetroZarytskyi
    PetroZarytskyi committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    f510256 View commit details
    Browse the repository at this point in the history

  4. Remove pointer arithmetic from VisitCallExpr by replacing pointers wi… 

    …th iterators
    @PetroZarytskyi
    PetroZarytskyi committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    bed0fbf View commit details
    Browse the repository at this point in the history

  5. Address clang-tidy complaints

    @PetroZarytskyi
    PetroZarytskyi committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    496e5e6 View commit details
    Browse the repository at this point in the history

  6. Improve test coverage of VisitCallExpr

    @PetroZarytskyi
    PetroZarytskyi committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    9648f43 View commit details
    Browse the repository at this point in the history

  7. Fix recursive call differentiation and add a test

    @PetroZarytskyi
    PetroZarytskyi committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    9aadd8f View commit details
    Browse the repository at this point in the history

  8. Move the checks of call arguments for being temporary exprs to a routine

    @PetroZarytskyi
    PetroZarytskyi committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    8c6d93c View commit details
    Browse the repository at this point in the history

  9. Remove redundant checks from VisitCallExpr

    @PetroZarytskyi
    PetroZarytskyi committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    453043e View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Move GetMultiArgCentralDiffCall to ReverseModeVisitor

    @PetroZarytskyi
    PetroZarytskyi committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    b340d05 View commit details
    Browse the repository at this point in the history