Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] Do not build the error estimation codes with differentiable clang #846

Merged
merged 2 commits into from
Apr 6, 2024

Conversation

vgvassilev
Copy link
Owner

We do not need to use a clad-compatible clang to build the error estimation demos.

This issue is related to #715.

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.76%. Comparing base (5b66f0e) to head (21fdf9e).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #846      +/-   ##
==========================================
- Coverage   94.82%   94.76%   -0.06%     
==========================================
  Files          49       49              
  Lines        7501     7495       -6     
==========================================
- Hits         7113     7103      -10     
- Misses        388      392       +4     

see 10 files with indirect coverage changes

see 10 files with indirect coverage changes

@vgvassilev vgvassilev force-pushed the ee-no-clang branch 2 times, most recently from 371be95 to 54dd037 Compare April 6, 2024 19:49
…lang.

We do not need to use a clad-compatible clang to build the error estimation
demos.
@vgvassilev
Copy link
Owner Author

The codecov report seems bogus, we do not touch any of the code but cmake.

@vgvassilev vgvassilev merged commit 87d2663 into master Apr 6, 2024
86 of 87 checks passed
@vgvassilev vgvassilev deleted the ee-no-clang branch April 6, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant