[cmake] Do not link libLLVM.so on platforms that enable it by default. #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #852 +/- ##
=======================================
Coverage 94.77% 94.77%
=======================================
Files 49 49
Lines 7499 7499
=======================================
Hits 7107 7107
Misses 392 392 |
AddLLVM.cmake can be configured in a way where it puts all LLVM libraries into a single libLLVM.so file. Then we can configure LLVM at build time to explicitly link libLLVM.so file to all targets that depend on llvm. That is very bad for plugins because it inserts the symbols once again into the binary causing double initialization of globals and other problems. This breaks the clad package for conda. This issue is related to #715.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddLLVM.cmake can be configured in a way where it puts all LLVM libraries into a single libLLVM.so file. Then we can configure LLVM at build time to explicitly link libLLVM.so file to all targets that depend on llvm. That is very bad for plugins because it inserts the symbols once again into the binary causing double initialization of globals and other problems.
This breaks the clad package for conda.
This issue is related to #715.