Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Enable clang-format on unittests #862

Merged
merged 1 commit into from
Apr 14, 2024
Merged

[ci] Enable clang-format on unittests #862

merged 1 commit into from
Apr 14, 2024

Conversation

vgvassilev
Copy link
Owner

No description provided.

@vgvassilev vgvassilev requested a review from vaithak April 13, 2024 15:00
@vaithak
Copy link
Collaborator

vaithak commented Apr 13, 2024

Will this work? In .clang-format, we have explicitly specified language as Cpp, and the test files are .C files.
I tested this locally, and it doesn't seem to be working for the test files.

@vgvassilev
Copy link
Owner Author

Will this work? In .clang-format, we have explicitly specified language as Cpp, and the test files are .C files.
I tested this locally, and it doesn't seem to be working for the test files.

If you mean the files in /test we should not format them however we should format the ones in /unittests. Is that what you mean?

@vaithak
Copy link
Collaborator

vaithak commented Apr 14, 2024

If you mean the files in /test we should not format them however we should format the ones in /unittests. Is that what you mean?

Yeah, I thought we meant to format /test

@vgvassilev vgvassilev merged commit 1881ac1 into master Apr 14, 2024
85 checks passed
@vgvassilev vgvassilev deleted the vgvassilev-patch-1 branch April 14, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaithak vaithak vaithak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vgvassilev @vaithak