Add support for null (empty) statements #900
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #900 +/- ##
==========================================
- Coverage 94.15% 94.09% -0.07%
==========================================
Files 53 53
Lines 7803 7805 +2
==========================================
- Hits 7347 7344 -3
- Misses 456 461 +5
... and 2 files with indirect coverage changes
|
|
Can you break the long commit message lines at 80-columns? This has been somewhat standard. |
| @@ -109,6 +109,7 @@ class BaseForwardModeVisitor | |||
| const clang::SubstNonTypeTemplateParmExpr* NTTP); | |||
| StmtDiff VisitImplicitValueInitExpr(const clang::ImplicitValueInitExpr* IVIE); | |||
| StmtDiff VisitCStyleCastExpr(const clang::CStyleCastExpr* CSCE); | |||
| StmtDiff VisitNullStmt(const clang::NullStmt* NS) { return StmtDiff{}; }; | |||
There was a problem hiding this comment.
I suspect there is a lot of such cases for the different types of statements. Maybe you can take a look at the statements we do not have a Visit routine for. Some of them could be as trivial and easy to test. That'd increase the coverage of supported things generally speaking.
There was a problem hiding this comment.
alright, I'll look for things like this
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
This commit removes the "unsupported" warning when differentiating code with ";" in both forward and reverse modes. It also prevents additional semicolons from getting pulled into the derivative code. Fixes: vgvassilev#899
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Codecov complains because now the NullStmts have their own routine and we do not fall back into |
This commit removes the "unsupported" warning when differentiating code with ";" in both forward and reverse modes. It also prevents additional semicolons from getting pulled into the derivative code.
Fixes: #899