Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for initializer_list in forward mode AD #935

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

parth-07
Copy link
Collaborator

This commit adds primitive support for initializer_list in the forward mode AD.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.86%. Comparing base (4f487e3) to head (20d08d4).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #935   +/-   ##
=======================================
  Coverage   93.86%   93.86%           
=======================================
  Files          55       55           
  Lines        7892     7894    +2     
=======================================
+ Hits         7408     7410    +2     
  Misses        484      484           
Files Coverage Δ
...clude/clad/Differentiator/BaseForwardModeVisitor.h 100.00% <ø> (ø)
lib/Differentiator/BaseForwardModeVisitor.cpp 98.95% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
...clude/clad/Differentiator/BaseForwardModeVisitor.h 100.00% <ø> (ø)
lib/Differentiator/BaseForwardModeVisitor.cpp 98.95% <100.00%> (+<0.01%) ⬆️

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@parth-07 parth-07 force-pushed the InitListForwMode branch 2 times, most recently from b179e19 to 5ca26d0 Compare June 26, 2024 21:02
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

This commit adds primitive support for initializer_list in the forward
mode AD.
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@parth-07 parth-07 requested a review from vgvassilev June 26, 2024 22:28
Copy link
Owner

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgvassilev vgvassilev merged commit 4c824ed into master Jun 27, 2024
89 checks passed
@vgvassilev vgvassilev deleted the InitListForwMode branch June 27, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants