Add shell.nix with an environment for building and using Clad on NixOS #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The testing and benchmarking relies on a hack that temporariliy changes the compiler flags. This doesn't work in all environments, and it would be nice if the the tests could be disabled so it's possible to build Clad without this hack. This makes it possible to build Clad on NixOS.
I use this nix environment to build Clad standalone and test the reproducers. Until recently, I could just use my native Arch Linux environment to do so, but after Arch dropped LLVM 17 this was not possible anymore (Clad doesn't work the LLVM 18 yet). Therefore, I had to find another solution, and nix packages works quite well. It would be nice to have this in the repo so also other people can work with Clad in NixOS, without having to waste time figuring out the dependencies and necessary CMake flags.
vgvassilev
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
I know nothing about Nix but that LGTM ;) Thank you, @guitargeek!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #973 +/- ##
=======================================
Coverage 93.94% 93.94%
=======================================
Files 55 55
Lines 7965 7965
=======================================
Hits 7483 7483
Misses 482 482 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use this nix environment to build Clad standalone and test the reproducers.
Until recently, I could just use my native Arch Linux environment to do
so, but after Arch dropped LLVM 17 this was not possible anymore (Clad
doesn't work the LLVM 18 yet). Therefore, I had to find another
solution, and nix packages works quite well.
It would be nice to have this in the repo so also other people can work
with Clad in NixOS, without having to waste time figuring out the
dependencies and necessary CMake flags.
Also, add a flag
CLAD_DISABLE_TESTSto the build system, so that Clad can be built without the hack of resetting the compiler flags temporarily by hand.