Directly set the adjoint of the LHS to 0 in assignments #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvassilev
reviewed
Jul 21, 2024
| // Add the statement `dl -= oldValue;` | ||
| addToCurrentBlock(BuildOp(BO_SubAssign, AssignedDiff, oldValue), | ||
| direction::reverse); | ||
| if (!isPointerOp) { |
There was a problem hiding this comment.
Out of curiosity, which are the pointer operations in which we should the old strategy?
There was a problem hiding this comment.
I didn't understand why pointers didn't work at first. The thing here is that for pointers, oldValue is nullptr and BuildOp(...) returns nullptr as well. Because of that, addToCurrentBlock(...) doesn't add anything to the block. So this line didn't do anything for pointers. But the new one does so I had to add a condition.
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #997 +/- ##
=======================================
Coverage 93.92% 93.92%
=======================================
Files 55 55
Lines 8034 8038 +4
=======================================
+ Hits 7546 7550 +4
Misses 488 488
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when we set the LHS of an assignment to 0 in the reverse mode, we do this by
This PR simplifies this process to