-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add base ESLint config #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ pending decision on explicit rule setting
I did my best to incorporate the app's ESLint config into the base config here. Intentional deviations from the app's explicit and/or effective config: Things that were explicitly errors and are now off
Things that were implicitly errors via
Things that were off and are now errors
Things that are no longer explicit, but still enabled from extended recommendations.
Other notes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff here, thank you!
This PR adds base ESLint config. I didn't add any rules, just base extensions. Could use help selecting more rules for this PR!