Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Three.js related dependency upgrade #432

Merged
merged 6 commits into from
Nov 20, 2023
Merged

Three.js related dependency upgrade #432

merged 6 commits into from
Nov 20, 2023

Conversation

micheal-parks
Copy link
Member

This PR upgrades all Three.js related dependencies, resolving an issue with color attributes that was fixed upstream in this PR.

It also accomplishes:

  • Fixed all instances of using workarounds for the color problem.
  • Fixed a grid rendering issue on the slam map I noticed when testing
  • Fixed a camera reprojection issue that arose somewhere from Three r155 -> r158

@micheal-parks micheal-parks merged commit 107ae04 into viamrobotics:main Nov 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanlookpotts ethanlookpotts ethanlookpotts approved these changes

@mcous mcous Awaiting requested review from mcous

@DTCurrie DTCurrie Awaiting requested review from DTCurrie

@mrloureed mrloureed Awaiting requested review from mrloureed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micheal-parks @ethanlookpotts