Upgrade client dependencies - June 2023 #2582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
ethanlook
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
nit: Rogue line addition?
There was a problem hiding this comment.
Woops, thanks for catching!
viambot
added
safe to test
|
@ethanlook I had to revert the prime upgrade as well because of |
Interesting, my understanding is that this only affects install from prime, not other projects. We definitely don't want to only allow consumers to use pnpm. Edit: 🤦🏻♂️ duh, preinstall runs when installing prime in other projects. I'll put up a PR to revert that line. |
|
@Otterverse Would you happen to know why so many checks are failing here? CI is giving issues unrelated to these changes. |
I think @edaniels broke it. :-) But also fixed it a short bit ago. faf57ab Rebase on main and try again. |
…ade-client-deps-jun-23
viambot
added
safe to test
Code Coverage
|
bazile-clyde
pushed a commit
to bazile-clyde/rdk
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This most notably upgrades us from Svelte 3 to 4. I had to hold off on upgrading THREE. There's an unknown issue from r152 -> r153 that disabled vertex colors on point clouds, causing probabilistic gray-scaling rendering of points to fail. I'll investigate this separately.