RSDK-5220 - Early exit reconfiguration on context.Done() #3020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
Code Coverage
|
stuqdog
approved these changes
Oct 2, 2023
maximpertsov
reviewed
Oct 2, 2023
| var wg sync.WaitGroup | ||
|
|
||
| mockAPI := resource.APINamespaceRDK.WithComponentType("mock") | ||
| modelName1 := utils.RandomAlphaString(5) |
There was a problem hiding this comment.
[minor] does this need to be random or can we just make it an obviously fake name? I think the latter is easier to debug should this test fail.
Suggested change
| modelName1 := utils.RandomAlphaString(5) | |
| modelName1 := "fakeModel" |
There was a problem hiding this comment.
random is slightly better so as to not run into issues registering multiple fakes across different tests (shouldn't be as bad nowadays since we deregister, but tests running in parallel might still run into issues
There was a problem hiding this comment.
gotcha - in that case could we use a uuid string to prevent a very unfortunately collision across parallel tests?
There was a problem hiding this comment.
I think RandomAlphaString is suitably random, can spin it out to a separate ticket to update all references (since there are a few) if we really want
maximpertsov
approved these changes
Oct 2, 2023
10zingpd
pushed a commit
that referenced
this pull request
Oct 2, 2023
bazile-clyde
pushed a commit
to bazile-clyde/rdk
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we get a cascade of resource configuration timeouts when we kill a server when it's hanging on reconfiguration, that was because we end up going through the reconfiguration for the rest of resources instead of exiting out early.
Should reduce noise when debugging issues