[RSDK-4975] CLI update warning #3585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjperez
requested review from
maximpertsov,
benjirewis,
cheukt and
zaporter-work
viambot
added
the
safe to test
|
This is still a draft, still needs tests and verification. Wanted to get feedback on the approach, messages, etc. before going further. |
viambot
added
safe to test
mattjperez
force-pushed
the
rsdk-4975-cli-upgrade-warning
branch
from
fb40338
to
a868377
Compare
benjirewis
reviewed
Feb 14, 2024
viambot
added
safe to test
|
to test the changes you can alter the following in |
viambot
added
safe to test
mattjperez
force-pushed
the
rsdk-4975-cli-upgrade-warning
branch
from
dbf3bbe
to
205cd07
Compare
viambot
added
safe to test
cheukt
reviewed
Feb 20, 2024
| TAG_VERSION?=$(shell git tag --points-at | sort -Vr | head -n1) | ||
| LDFLAGS = -ldflags "-s -w -extld="$(shell pwd)/etc/ld_wrapper.sh" -X 'go.viam.com/rdk/config.Version=${TAG_VERSION}' -X 'go.viam.com/rdk/config.GitRevision=${GIT_REVISION}'" | ||
| TAG_VERSION?=$(shell git tag --points-at | sort -Vr | head -n1 | grep . || echo "(dev)") | ||
| DATE_COMPILED?=$(shell date +'%Y-%m-%d') |
There was a problem hiding this comment.
[opt] A friend of mine mentioned that using the go debug vcs.time would work as well.
See: https://pkg.go.dev/runtime/debug#BuildSetting
We report this in viam --debug version
Note: if you compile the cli with go build ./viam/main.go the vcs debug info won't be there. golang/go#51279
I don't want to drag down this PR in refactors so I don't see a strong reason to do this now, but might be worth considering in the future.
maximpertsov
approved these changes
Feb 20, 2024
viambot
added
safe to test
cheukt
approved these changes
Feb 20, 2024
| @@ -380,6 +387,129 @@ func RobotsPartShellAction(c *cli.Context) error { | |||
| ) | |||
| } | |||
|
|
|||
| // checkUpdateResponse holds the values used to hold release information. | |||
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSDK-4975
On installs older than one week, warns users when their CLI is out of date against the latest stable release.