[APP 2911] Step Towards Removal of Legacy Robot API Keys #4374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
viambot
added
safe to test
bashar-515
changed the title
viambot
added
safe to test
bashar-515
force-pushed
the
APP-2911
branch
from
3fb0c62
to
8c8660a
Compare
viambot
added
safe to test
bashar-515
force-pushed
the
APP-2911
branch
from
9f5ea2a
to
8c8660a
Compare
viambot
added
safe to test
viambot
added
safe to test
maxhorowitz
approved these changes
Sep 24, 2024
|
Removing @ohEmily as a reviewer to unblock, resyncing w/ @maxhorowitz like discussed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR phases out support for legacy robot API keys by taking out most of the code that explicitly parses for them via a "key" field in the API key handler config. Some code still remains to account for a "keys" field. This is redundant, but it's required for backwards compatibility - also the only remaining artifact of legacy keys. Also in this PR is the reconfiguration of various tests in order to account for the change in App slightly affecting the structure of the API key auth config.
Testing: local testing suites pass and my dummy local robot as able to connect manually.