RSDK-8838: Use SetRPM in gantry homing routine #4380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martha-johnston
requested review from
a team and
JohnN193
and removed request for
a team
viambot
added
the
safe to test
JohnN193
reviewed
Sep 23, 2024
good point I should add injected SetRPM funcs. the other gantries are fake and don't use GoFor or the multi-axis implementation which just combines multiple single-axis implementations and doesn't really make any movement calls on its own |
viambot
added
safe to test
JohnN193
approved these changes
Sep 23, 2024
maximpertsov
pushed a commit
to maximpertsov/rdk
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using SetRPM instead of GoFor with revolutions == 0 (removed behavior) when homing and moving away from a limit switch.