Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-8736: Only keep last error instead of joining #4390

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

maximpertsov
Copy link
Contributor

viam-server can have multiple successive config failures very quickly, which leads to some very long error messages

@maximpertsov maximpertsov requested a review from a team September 24, 2024 21:39
@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Sep 24, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Sep 24, 2024
@dgottlieb dgottlieb changed the title Only keep last error instead of joining RSDK-8736: Only keep last error instead of joining Sep 25, 2024
@dgottlieb dgottlieb merged commit 77cbddd into viamrobotics:main Sep 25, 2024
19 checks passed
maximpertsov added a commit to maximpertsov/rdk that referenced this pull request Sep 27, 2024
maximpertsov added a commit to maximpertsov/rdk that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants