RSDK-8824: Test Datarace: go.viam.com/rdk/components/base/sensorcontrolled.TestSensorBaseWithVelocitiesSensor #4395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
|
I don't think there was a particular reason, I tried to ask why we didn't have locks in the past and never got a response back. Chose not to add locks because we had a ticket to fix the controls/motor tests so figured all the other blocks could happen then. |
JohnN193
approved these changes
Sep 25, 2024
they all still fail |
|
going to run more extensive hardware tests tomorrow to make sure this doesn't break anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after further investigation the issue was in the
Next()function of various blocks. I added a lock to each, but I'm wondering if this will cause issues. @JohnN193 do you remember why we haven't done this yet? I did a quick test with tuning and behavior of controlled components with these changes and didn't see any issues