Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-6222 upgrade to go 1.23 #4401

Merged
merged 12 commits into from
Oct 1, 2024
Merged

APP-6222 upgrade to go 1.23 #4401

merged 12 commits into from
Oct 1, 2024

Conversation

abe-winter
Copy link
Member

@abe-winter abe-winter commented Sep 30, 2024

What changed

  • bump go.mod to go 1.23
  • upgrade linter because old v1.51.0 one isn't compatible with new golang
  • nolint comments, disabled linters, and other linter setting changes

Why

go 1.21 is EOL

Test runs

New linters

We should re-enable some of the useful linters (esp new intrange + copyloopvar stuff) in a separate PR.

Pre-merge checklist

  • revert test-in-branch changes
  • promote the -go123 images to main + test them with docker.yml. (these can't be released ahead of time because v1.51.0 of the linter, or some sub-linters, aren't compatible w/ go 1.23)
  • install go 1.23 on pi runners

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Sep 30, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Sep 30, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Sep 30, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Sep 30, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Sep 30, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Sep 30, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Sep 30, 2024
@abe-winter abe-winter marked this pull request as ready for review September 30, 2024 22:22
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Sep 30, 2024
Copy link
Contributor

Availability

Scene # viamrobotics:main viamrobotics:aw-go123 Percent Improvement Health
1 100% 100% 0%
2 100% 100% 0%
3 100% 100% 0%
4 100% 100% 0%
5 90% 90% 0%
6 70% 70% 0%
7 30% 20% -33%
8 100% 100% 0%
9 90% 90% 0%
10 100% 100% 0%
11 100% 100% 0%
12 100% 100% 0%
13 100% 100% 0%
14 100% 100% 0%
15 100% 100% 0%
16 90% 90% 0%
17 100% 100% 0%
18 70% 70% 0%

Quality

Scene # viamrobotics:main viamrobotics:aw-go123 Percent Improvement Probability of Improvement Health
1 1.31±0.00 1.31±0.00 -0% 50%
2 0.90±0.00 0.90±0.00 -0% 50%
3 2.48±0.13 2.48±0.13 -0% 50%
4 4.23±1.34 4.36±1.09 -3% 47%
5 14.83±6.04 15.91±5.16 -7% 45%
6 16.23±3.86 16.61±4.13 -2% 47%
7 4.35±1.86 5.28±1.61 -21% 35%
8 4.99±1.08 4.99±1.08 -0% 50%
9 4.52±0.14 4.52±0.14 0% 50%
10 4.13±0.34 4.12±0.33 0% 51%
11 3.13±0.00 3.13±0.00 -0% 50%
12 3.91±0.85 4.00±0.98 -2% 47%
13 904.77±13.78 904.77±13.78 -0% 50%
14 2035.66±601.28 2035.67±601.28 -0% 50%
15 50790.10±9415.58 50790.10±9415.58 -0% 50%
16 59103.42±7272.96 59103.42±7272.96 -0% 50%
17 15936.40±3302.53 15936.40±3302.53 -0% 50%
18 120318.91±14538.82 120138.93±14674.41 0% 50%

Performance

Scene # viamrobotics:main viamrobotics:aw-go123 Percent Improvement Probability of Improvement Health
1 0.09±0.01 0.09±0.01 2% 60%
2 0.11±0.01 0.11±0.01 -0% 49%
3 1.01±0.62 1.02±0.62 -0% 50%
4 2.01±0.13 2.00±0.14 1% 53%
5 2.70±0.96 2.79±0.92 -3% 47%
6 3.19±0.83 3.10±0.87 3% 53%
7 2.69±0.58 2.92±0.58 -9% 39%
8 0.40±0.15 0.39±0.15 2% 51%
9 5.03±0.15 4.98±0.16 1% 60%
10 0.14±0.02 0.14±0.02 -2% 46%
11 0.10±0.00 0.10±0.01 0% 51%
12 0.13±0.01 0.13±0.01 1% 53%
13 0.07±0.01 0.08±0.01 -0% 49%
14 0.80±0.28 0.80±0.28 0% 50%
15 1.14±0.18 1.12±0.18 1% 52%
16 2.53±0.81 2.56±0.81 -1% 49%
17 1.33±0.14 1.30±0.14 2% 56%
18 4.68±0.77 4.69±0.77 -0% 50%

The above data was generated by running scenes defined in the motion-testing repository
The SHA1 for viamrobotics:main is: 900738751a11aa6be03dd90a3932f38e1c35f187
The SHA1 for viamrobotics:aw-go123 is: 900738751a11aa6be03dd90a3932f38e1c35f187

  • 10 samples were taken for each scene
  • A timeout of 5.0 seconds was imposed for each trial

Copy link
Member

@Otterverse Otterverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this!

@abe-winter abe-winter merged commit a8fcbb2 into main Oct 1, 2024
27 of 35 checks passed
@abe-winter abe-winter deleted the aw-go123 branch October 1, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants