Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-8887 Update to prevent nil panics in framesystem #4405

Conversation

biotinker
Copy link
Member

This adds nil and error checks to prevent nil panics.

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Sep 30, 2024
Copy link
Contributor

Availability

Scene # viamrobotics:main biotinker:20240930_RSDK-8887-nil-panic-error-return-in-framsystem Percent Improvement Health
1 100% 100% 0%
2 100% 100% 0%
3 100% 100% 0%
4 100% 100% 0%
5 90% 90% 0%
6 70% 70% 0%
7 20% 10% -50%
8 100% 100% 0%
9 90% 90% 0%
10 100% 100% 0%
11 100% 100% 0%
12 100% 100% 0%
13 100% 100% 0%
14 100% 100% 0%
15 100% 100% 0%
16 90% 90% 0%
17 100% 100% 0%
18 70% 70% 0%

Quality

Scene # viamrobotics:main biotinker:20240930_RSDK-8887-nil-panic-error-return-in-framsystem Percent Improvement Probability of Improvement Health
1 1.31±0.00 1.31±0.00 -0% 50%
2 0.90±0.00 0.90±0.00 -0% 50%
3 2.48±0.13 2.48±0.13 -0% 50%
4 4.49±1.30 4.03±1.14 10% 61%
5 15.49±5.27 14.62±4.34 6% 55%
6 14.27±4.74 16.77±4.29 -18% 35%
7 5.28±1.61 6.89±0.00 -30% 16%
8 4.99±1.08 4.99±1.08 -0% 50%
9 4.52±0.14 4.47±0.18 1% 59%
10 4.20±0.36 4.13±0.34 2% 56%
11 3.13±0.00 3.13±0.00 -0% 50%
12 4.00±0.98 3.91±0.85 2% 53%
13 904.77±13.78 904.77±13.78 -0% 50%
14 2035.67±601.28 2035.67±601.28 -0% 50%
15 50790.10±9415.58 50790.10±9415.58 -0% 50%
16 59103.42±7272.96 59103.42±7272.96 -0% 50%
17 15936.40±3302.53 15936.40±3302.53 -0% 50%
18 119737.10±14514.08 119838.44±14937.25 -0% 50%

Performance

Scene # viamrobotics:main biotinker:20240930_RSDK-8887-nil-panic-error-return-in-framsystem Percent Improvement Probability of Improvement Health
1 0.09±0.01 0.09±0.01 -1% 47%
2 0.11±0.01 0.11±0.01 -4% 36%
3 1.00±0.62 1.01±0.62 -1% 49%
4 2.03±0.13 1.97±0.12 3% 64%
5 2.81±0.91 2.95±1.08 -5% 46%
6 3.13±0.88 3.04±0.90 3% 53%
7 2.92±0.59 3.52±0.00 -20% 16%
8 0.40±0.15 0.40±0.15 -0% 50%
9 5.01±0.16 5.00±0.14 0% 52%
10 0.14±0.02 0.14±0.02 -0% 50%
11 0.10±0.00 0.10±0.00 -0% 48%
12 0.13±0.01 0.13±0.01 1% 54%
13 0.07±0.01 0.07±0.01 1% 53%
14 0.79±0.28 0.80±0.28 -1% 50%
15 1.14±0.16 1.13±0.17 1% 52%
16 2.53±0.82 2.55±0.80 -1% 50%
17 1.32±0.16 1.29±0.16 2% 55%
18 4.68±0.75 4.67±0.78 0% 50%

The above data was generated by running scenes defined in the motion-testing repository
The SHA1 for viamrobotics:main is: 900738751a11aa6be03dd90a3932f38e1c35f187
The SHA1 for biotinker:20240930_RSDK-8887-nil-panic-error-return-in-framsystem is: 900738751a11aa6be03dd90a3932f38e1c35f187

  • 10 samples were taken for each scene
  • A timeout of 5.0 seconds was imposed for each trial

@biotinker biotinker merged commit 59e3c5c into viamrobotics:main Sep 30, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants