APP-6850 update android build for go 1.23 #4539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
seanavery
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
LGTM.
We recently had to add this flag to viamrtsp as well because of golang bump.
hexbabe
pushed a commit
to hexbabe/sean-rdk
that referenced
this pull request
Nov 14, 2024
hexbabe
pushed a commit
to hexbabe/sean-rdk
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Add linker flag in
droid-rdk.aarmakefile targetWhy
See https://github.com/wlynxg/anet#how-to-build-with-go-1230-or-later -- this is required to work around go:linkname being deprecated.
Without this change,
make droid-rdk.aarfails with: