Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-8611: Have test make a tls config copy to avoid concurrent access. #4544

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

dgottlieb
Copy link
Member

No description provided.

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Nov 8, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 8, 2024
Copy link
Member

@Kschappacher Kschappacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would recommend doing a go test -count 100 to ensure it helps fix the flakey test.

@dgottlieb dgottlieb merged commit 6df1e62 into viamrobotics:main Nov 8, 2024
17 checks passed
@dgottlieb dgottlieb deleted the RSDK-8611 branch November 8, 2024 18:48
hexbabe pushed a commit to hexbabe/sean-rdk that referenced this pull request Nov 14, 2024
hexbabe pushed a commit to hexbabe/sean-rdk that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants