RSDK-3008 - add misc-unused-params #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuqdog
commented
Feb 20, 2024
| @@ -24,7 +24,8 @@ class GenericComponent : public Component { | |||
| /// @brief Send/receive arbitrary commands to the resource. | |||
| /// @param command the command to execute. | |||
| /// @return The result of the executed command. | |||
| virtual AttributeMap do_command(AttributeMap command) = 0; | |||
| // CR erodkin: flyby | |||
| virtual AttributeMap do_command(const AttributeMap& command) = 0; | |||
There was a problem hiding this comment.
(flyby) make arg const&.
Comment on lines
33
to
36
| this->peek_current_pose = destination; | ||
| this->peek_component_name = component_name; | ||
| this->peek_slam_name = slam_name; | ||
| this->current_location.pose = destination; |
There was a problem hiding this comment.
(flyby) here and below, moveing these args is meaningless because they're const&, and we can't make them not const& here without modifying the signature in the Motion base class. So, we get rid of the move.
stuqdog
requested review from
njooma,
purplenicole730 and
acmorrow
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.