Automated Protos Update #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
force-pushed
the
workflow/update-protos
branch
from
2fe5da5
to
a5b9446
Compare
github-actions
bot
requested review from
njooma and
purplenicole730
and removed request for
a team
github-actions
bot
force-pushed
the
workflow/update-protos
branch
3 times, most recently
from
ad52b6e
to
16e4193
Compare
github-actions
bot
force-pushed
the
workflow/update-protos
branch
from
16e4193
to
ea086e0
Compare
penguinland
added a commit
that referenced
this pull request
May 9, 2024
This turned out to be two problems combined! 1) update the SDK to use a more recent version of the protobufs in the API repo, and then 2) remove the `Status` RPC from the boards. The PR isn't quite done: I'm unsure how this should interact with #230, which is where the compiled version of the updated protos is. but the rest I think is ready for a look. Updating the protobufs was harder than I expected: viamrobotics/api#470 (unrelated to boards) added a new type that had not been used previously, which meant that getting it to work required updating CMakeLists.txt to include the Google libraries for the new type. Changes to boards: - `get_status` doesn't exist any more. You can get the standard status from a component the same way you would for a motor, but there isn't a special board-specific one any more. - In the component status you _can_ get, analog and digital interrupt values are stored as ints, not wrappers around ints. No need to unwrap. - `get_analog_names` and `get_digital_interrupt_names` can't easily be implemented any more. They don't exist in the Flutter and TypeScript SDKs, and are hopefully being removed from the Go and Python SDKs soon (they have a purpose on the server side, but no obvious use on the client side, so probably shouldn't be in these SDKs). So, I removed them. - Similarly, I removed `get_analog_readers` and `get_digital_interrupts`, as they're not present in the Go SDK and would be very hard to implement without the old status.
…f993228e5900f376006033be07036
github-actions
bot
force-pushed
the
workflow/update-protos
branch
from
cdafd50
to
2cc0357
Compare
stuqdog
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an auto-generated PR to update proto definitions. Check the commits to see which repos and commits are responsible for the changes