Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-5378 - allow setting of cpp standard #234

Merged
merged 2 commits into from
May 16, 2024
Merged

RSDK-5378 - allow setting of cpp standard #234

merged 2 commits into from
May 16, 2024

Conversation

stuqdog
Copy link
Member

@stuqdog stuqdog commented May 13, 2024

No description provided.

@stuqdog stuqdog requested a review from acmorrow May 13, 2024 19:01
@stuqdog stuqdog requested a review from a team as a code owner May 13, 2024 19:01
@stuqdog stuqdog requested review from njooma and purplenicole730 and removed request for a team May 13, 2024 19:01
acmorrow
acmorrow approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@acmorrow acmorrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Future work here would be to ensure that we 1) propagate the selected CMAKE_CXX_STANDARD as a public requirement on the produced libraries, and 2) continue to do that correctly if one of our dependencies (cough cough abseil) forces the matter.

@stuqdog stuqdog merged commit 88158f3 into viamrobotics:main May 16, 2024
3 checks passed
@stuqdog stuqdog deleted the allow-setting-of-cpp-standard branch May 16, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acmorrow acmorrow acmorrow approved these changes

@njooma njooma Awaiting requested review from njooma njooma is a code owner automatically assigned from viamrobotics/sdk-netcode

@purplenicole730 purplenicole730 Awaiting requested review from purplenicole730 purplenicole730 is a code owner automatically assigned from viamrobotics/sdk-netcode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuqdog @acmorrow