[RSDK-7151] Update analog reader responses to include accuracy data #237
Conversation
penguinland
requested review from
njooma and
purplenicole730
and removed request for
a team
There was a problem hiding this comment.
I've resolved my tension between statuses holding just an int32 while the analog responses now hold 4 pieces of data: keep statuses as just an int32, and only change the return type when reading analogs! This got rid of half the things Drew suggested needed fixing, and I like the design better. Take another look!
| @@ -103,8 +103,11 @@ ::grpc::Status BoardServer::ReadAnalogReader( | |||
| extra = struct_to_map(request->extra()); | |||
| } | |||
|
|
|||
| const Board::analog_value result = board->read_analog(request->analog_reader_name(), extra); | |||
| response->set_value(result); | |||
| const Board::analog_response result = board->read_analog(request->analog_reader_name(), extra); | |||
There was a problem hiding this comment.
I named the type analog_response, but named all the variables result. Should the type be analog_result instead? I'm unsure...
|
The CI build is failing with |
@penguinland not sure what's going on with this but it's not a problem on your end; it's popping up in other PRs as well. I'll investigate. Edit: okay I'm pretty sure I have a fix, confirming now then will merge it into main. |
penguinland
force-pushed
the
analog_reader_accuracy
branch
from
276bfe2
to
2d655c8
Compare
|
Yup, I rebased off of |
Surprisingly, we don't need a protobuf update (from viamrobotics/api#492) because we're already using the new protobufs and have just been ignoring the extra data they hold!
Everything compiles and the tests all pass, though I haven't tried it out more than that.