RSDK-7642 - add simple module client for module integration testing #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuqdog
requested review from
njooma and
lia-viam
and removed request for
a team
lia-viam
approved these changes
Jun 25, 2024
lia-viam
reviewed
Jun 25, 2024
| @@ -25,3 +25,18 @@ install( | |||
| TARGETS simple_module | |||
| COMPONENT examples | |||
| ) | |||
|
|
|||
| add_executable(simple_module_client) | |||
| target_sources(simple_module_client | |||
There was a problem hiding this comment.
just for my own curiosity is there a reason we do it this way (also for add_library calls in the sdk) instead of just add_executable(simple_module_client client.cpp)
There was a problem hiding this comment.
That's my doing. I like being consistent about using the target_xyz calls to affect the target rather than having some of them apply at the declaration and others (e.g. target_link_libraries) be called for side effects. Since target_sources works like target_link_libraries I used it consistently everywhere, and left the add_executable and add_library calls are purely introducing the name with no side effects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a simple module client for use in module integration tests.