Fix aarch build #282
Merged
Fix aarch build #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lia-viam
requested review from
njooma and
purplenicole730
and removed request for
a team
|
See https://github.com/viamrobotics/viam-cpp-sdk/actions/runs/10457957698 for that this fixes the issue |
stuqdog
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix failures seen it the latest draft release, see eg
https://github.com/viamrobotics/viam-cpp-sdk/actions/runs/10457244069/job/28956432798#step:7:326
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54483#c13
For whatever reason this was only failing on the aarch c++14 linux builds, although it seems they were correct to fail it.