Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the library Multiplatform and upgrade config #11

Open
HLCaptain opened this issue Feb 29, 2024 · 3 comments · May be fixed by #14
Open

Make the library Multiplatform and upgrade config #11

HLCaptain opened this issue Feb 29, 2024 · 3 comments · May be fixed by #14
Assignees
Labels
enhancement New feature or request

Comments

@HLCaptain
Copy link

I would like to use this library in multiple Kotlin Multiplatform projects of mine, but only JVM is supported. I found a crypto library, which implements SecureRandom, as well as multiple stable random libraries across other platforms to be used in common code.

The modification also comes with configuration change to using Kotlin Gradle DSL.

I already forked this repository and made my changes (not finalized yet).

@itsmefox itsmefox added the enhancement New feature or request label Mar 4, 2024
@HLCaptain
Copy link
Author

Just so we don't duplicate work, @nik-sta should I attempt to finish up my changes and make a PR, or is it your task to find a proper way to make the library multiplatform? Either way, I am happy to assist and make changes! :)

@nik-sta
Copy link
Member

nik-sta commented Mar 19, 2024

Hi, @HLCaptain. Thanks for taking the time to discuss your changes with us. Generally speaking, we like your proposal and code changes. The one detail we need to work on (or make up our minds) is whether there is an alternative for the crypto library. The proposed one is unacceptable and insufficient to accept using it, as we aim to use standards and well-established libraries only.

You are more than welcome to contribute to this repo; therefore, please make your pull request, and we can work together on it :)

Using only the cryptography-random module, as it is nicely structured, would be one improvement, but as it is currently in version 0.3.0 and relatively new, it remains a risk.

@itsmefox
Copy link
Member

We would highly welcome the change to make this library multiplatform capable. Let's find a way together to make this possible.

@HLCaptain HLCaptain linked a pull request Mar 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants