Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made NanoId Multiplatform and using Kotlin Gradle DSL #14

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

HLCaptain
Copy link

@HLCaptain HLCaptain commented Mar 23, 2024

Migrated Gradle build files to use the statically typed Kotlin Gradle DSL.

Using korlibs-crypto to provide SecureRandom for each platform. Implementations are based on top of:

May need to modify the PR build config to enable platforms explicitly and run tests on them.

closes #11

@HLCaptain HLCaptain marked this pull request as ready for review March 23, 2024 20:45
@nik-sta nik-sta marked this pull request as draft March 25, 2024 15:49
@nik-sta nik-sta requested review from itsmefox and nik-sta March 25, 2024 15:49
@HLCaptain HLCaptain marked this pull request as ready for review March 25, 2024 18:28
@HLCaptain HLCaptain marked this pull request as draft March 26, 2024 09:55
@writtmeyer
Copy link

I like this KMP change, but I think korlibs-crypto is now no longer standalone. Maybe replace it with one of these KMP alternatives?

@HLCaptain
Copy link
Author

For crypto, I don't see SecureRandom implementation which this library is based upon. I think secure-random would be a great alternative, but as pointed out in this comment, we are aiming to build upon stable libraries and implementations, which I can't confidently say about secure-random. korlibs-crypto remains as the only stable and taken care of library for now in my opinion. But if the team is flexible enough, I can give secure-random a go.

@HLCaptain HLCaptain marked this pull request as ready for review May 8, 2024 16:19
@HLCaptain
Copy link
Author

Opened up PR for review, as no direct feedback was given on the concern of using korlibs-crypto as a library providing SecureRandom. korlibs-crypto is standalone in a sense, that it has its own artifact, independent from other korlibs libraries.

@itsmefox
Copy link
Member

I had a short look at this PR. I did a clean build publishJvmPublicationToMavenLocal, but there seems to be an issue with the build, as the jar does not contain any code.

CleanShot 2024-07-29 at 09 49 49@2x

Also, the artefact name for the jvm build gets changed to nanoid-jvm. We want this to stay for jvm as it is now: nanoid

@HLCaptain HLCaptain marked this pull request as draft July 29, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the library Multiplatform and upgrade config
3 participants