Skip to content

Commit

Permalink
Fix lint error that invoke class static function from class instance.
Browse files Browse the repository at this point in the history
  • Loading branch information
tcw165 committed Sep 8, 2022
1 parent d05ef1b commit 364c104
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 15 deletions.
1 change: 1 addition & 0 deletions src/rpp/rpp/schedulers/trampoline_scheduler.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ class trampoline final : public details::scheduler_tag
}

static time_point now() { return clock_type::now(); }

private:
rpp::composite_subscription m_sub;
};
Expand Down
25 changes: 10 additions & 15 deletions src/tests/test_schedulers.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -417,9 +417,8 @@ SCENARIO("New thread scheduler depends on subscription")

SCENARIO("trampoline scheduler dispatches task in the same thread")
{
auto scheduler = rpp::schedulers::trampoline{};
auto sub = rpp::composite_subscription{};
auto worker = scheduler.create_worker(sub);
auto sub = rpp::composite_subscription{};
auto worker = rpp::schedulers::trampoline::create_worker(sub);

WHEN("supply a simple job")
{
Expand Down Expand Up @@ -472,9 +471,8 @@ static std::vector<std::string> trampoline_expected_simulate_nested_scheduling(s
}
SCENARIO("trampoline scheduler defers tasks in order")
{
auto scheduler = rpp::schedulers::trampoline{};
auto sub = rpp::composite_subscription{};
auto worker = scheduler.create_worker(sub);
auto sub = rpp::composite_subscription{};
auto worker = rpp::schedulers::trampoline::create_worker(sub);
rpp::subscription_guard guard{sub};

WHEN("supply a job that schedules inner job that schedules inner job")
Expand All @@ -494,9 +492,8 @@ SCENARIO("trampoline scheduler is thread local")
{
WHEN("two threads are using the same trampoline scheduler")
{
auto scheduler = rpp::schedulers::trampoline{};
auto sub = rpp::composite_subscription{};
auto worker = scheduler.create_worker(sub);
auto sub = rpp::composite_subscription{};
auto worker = rpp::schedulers::trampoline::create_worker(sub);
rpp::subscription_guard guard{sub};

std::vector<std::string> call_stack_1;
Expand All @@ -517,9 +514,8 @@ SCENARIO("trampoline scheduler regards unsubscribed subscription")
{
GIVEN("unsubscribed subscription")
{
auto scheduler = rpp::schedulers::trampoline{};
auto sub = rpp::composite_subscription{};
auto worker = scheduler.create_worker(sub);
auto sub = rpp::composite_subscription{};
auto worker = rpp::schedulers::trampoline::create_worker(sub);

sub.unsubscribe();

Expand All @@ -535,9 +531,8 @@ SCENARIO("trampoline scheduler regards unsubscribed subscription")

GIVEN("asynchronously unsubscribes subscription")
{
auto scheduler = rpp::schedulers::trampoline{};
auto sub = rpp::composite_subscription{};
auto worker = scheduler.create_worker(sub);
auto sub = rpp::composite_subscription{};
auto worker = rpp::schedulers::trampoline::create_worker(sub);

THEN("shall not see execution of inner schedulable")
{
Expand Down

0 comments on commit 364c104

Please sign in to comment.