Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
  • Loading branch information
victimsnino and coderabbitai[bot] authored Oct 18, 2024
1 parent 7b81de8 commit 43beada
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/rpp/rpp/disposables/details/container.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ namespace rpp::details::disposables
public:
[[noreturn]] static void push_back(const rpp::disposable_wrapper&)
{
throw rpp::utils::more_disposables_than_expected{"static_disposables_container<0> expected none disposables but obtained at least one"};
throw rpp::utils::more_disposables_than_expected{"static_disposables_container<0> expected no disposables but received at least one"};
}

static void remove(const rpp::disposable_wrapper&) {}
Expand Down
2 changes: 1 addition & 1 deletion src/rpp/rpp/observers/observer.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ namespace rpp
* @warning By default observer is not copyable, only movable. If you need to COPY your observer, you need to convert it to rpp::dynamic_observer via rpp::observer::as_dynamic
* @warning Expected that observer would be subscribed only to ONE observable ever. It can keep internal state and track it it was disposed or not. So, subscribing same observer multiple time follows unspecified behavior.
* @warning If you are passing disposable to ctor, then state of this disposable would be used used (if empty disposable or disposed -> observer is disposed by default)
* @warning It is expected, that member of this observer would be called in SERIAL way. It means, no any parallel/concurrect calls allowed, only serial or guarded under lock.
* @warning It is expected that members of this observer are called in a SERIAL manner. This means no parallel or concurrent calls are allowed—only serial calls or those guarded under a lock.
*
* @tparam Type of value this observer can handle
* @tparam Strategy used to provide logic over observer's callbacks
Expand Down

0 comments on commit 43beada

Please sign in to comment.