-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "take_until" operator. #235
Conversation
Codecov Report
@@ Coverage Diff @@
## main #235 +/- ##
==========================================
+ Coverage 98.20% 98.32% +0.11%
==========================================
Files 93 95 +2
Lines 1340 1376 +36
==========================================
+ Hits 1316 1353 +37
+ Misses 24 23 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
b7342b5
to
3369405
Compare
BENCHMARK RESULTS (AUTOGENERATED)ci-ubuntu-clangObservable constructionTable
Observable liftTable
Observable subscribeTable
Observable subscribe #2Table
Observer constructionTable
OnNextTable
Subscriber constructionTable
SubscriptionTable
bufferTable
chains creation testTable
combine_latestTable
concatTable
distinct_until_changedTable
firstTable
foundamental sourcesTable
fromTable
immediate schedulerTable
justTable
mapTable
mergeTable
observe_onTable
publish_subject callbacksTable
publish_subject routinesTable
repeatTable
scanTable
skipTable
switch_on_nextTable
takeTable
take_lastTable
take_untilTable
trampoline schedulerTable
windowTable
with_latest_fromTable
ci-ubuntu-gccObservable constructionTable
Observable liftTable
Observable subscribeTable
Observable subscribe #2Table
Observer constructionTable
OnNextTable
Subscriber constructionTable
SubscriptionTable
bufferTable
chains creation testTable
combine_latestTable
concatTable
distinct_until_changedTable
firstTable
foundamental sourcesTable
fromTable
immediate schedulerTable
justTable
mapTable
mergeTable
observe_onTable
publish_subject callbacksTable
publish_subject routinesTable
repeatTable
scanTable
skipTable
switch_on_nextTable
takeTable
take_lastTable
take_untilTable
trampoline schedulerTable
windowTable
with_latest_fromTable
ci-windowsObservable constructionTable
Observable liftTable
Observable subscribeTable
Observable subscribe #2Table
Observer constructionTable
OnNextTable
Subscriber constructionTable
SubscriptionTable
bufferTable
chains creation testTable
combine_latestTable
concatTable
distinct_until_changedTable
firstTable
foundamental sourcesTable
fromTable
immediate schedulerTable
justTable
mapTable
mergeTable
observe_onTable
publish_subject callbacksTable
publish_subject routinesTable
repeatTable
scanTable
skipTable
switch_on_nextTable
takeTable
take_lastTable
take_untilTable
trampoline schedulerTable
windowTable
with_latest_fromTable
|
3369405
to
0b65427
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
12efeac
to
71d4f20
Compare
Rebased |
3b44431
to
1eca4d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks much better
b313e53
to
443536e
Compare
a2ea55a
to
80f4507
Compare
80f4507
to
34ba54a
Compare
9c8b4c4
to
d6be308
Compare
d6be308
to
241fa1a
Compare
@victimsnino The "early-unsubscribing" fixes the race condition among |
Kudos, SonarCloud Quality Gate passed! |
No description provided.