-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add combining operators (reduce, average, min, max, sum, count) #316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/2)
Codecov Report
@@ Coverage Diff @@
## main #316 +/- ##
==========================================
+ Coverage 97.83% 97.88% +0.04%
==========================================
Files 112 114 +2
Lines 1712 1795 +83
==========================================
+ Hits 1675 1757 +82
- Misses 37 38 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (2/2)
{ | ||
for (size_t i = 0; i < 10; ++i) | ||
{ | ||
auto copy = sub; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
local copy copy
of the variable sub
is never modified; consider avoiding the copy
auto copy = sub; | |
const auto copy = sub; |
{ | ||
for (size_t i = 0; i < 10; ++i) | ||
{ | ||
auto copy = sub; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
local copy copy
of the variable sub
is never modified; consider avoiding the copy
auto copy = sub; | |
auto& copy = sub; |
BENCHMARK RESULTS (AUTOGENERATED)ci-macosObservable constructionTable
Observable liftTable
Observable subscribeTable
Observable subscribe #2Table
Observer constructionTable
OnNextTable
Subscriber constructionTable
SubscriptionTable
bufferTable
chains creation testTable
combine_latestTable
concatTable
distinct_until_changedTable
firstTable
foundamental sourcesTable
fromTable
immediate schedulerTable
justTable
lastTable
mapTable
mergeTable
observe_onTable
on_error_resume_nextTable
publish_subject callbacksTable
publish_subject routinesTable
repeatTable
scanTable
single-threaded locksTable
skipTable
switch_on_nextTable
takeTable
take_lastTable
take_untilTable
timeoutTable
trampoline schedulerTable
windowTable
with_latest_fromTable
ci-ubuntu-clangObservable constructionTable
Observable liftTable
Observable subscribeTable
Observable subscribe #2Table
Observer constructionTable
OnNextTable
Subscriber constructionTable
SubscriptionTable
bufferTable
chains creation testTable
combine_latestTable
concatTable
distinct_until_changedTable
firstTable
foundamental sourcesTable
fromTable
immediate schedulerTable
justTable
lastTable
mapTable
mergeTable
observe_onTable
on_error_resume_nextTable
publish_subject callbacksTable
publish_subject routinesTable
repeatTable
scanTable
single-threaded locksTable
skipTable
switch_on_nextTable
takeTable
take_lastTable
take_untilTable
timeoutTable
trampoline schedulerTable
windowTable
with_latest_fromTable
ci-ubuntu-gccObservable constructionTable
Observable liftTable
Observable subscribeTable
Observable subscribe #2Table
Observer constructionTable
OnNextTable
Subscriber constructionTable
SubscriptionTable
bufferTable
chains creation testTable
combine_latestTable
concatTable
distinct_until_changedTable
firstTable
foundamental sourcesTable
fromTable
immediate schedulerTable
justTable
lastTable
mapTable
mergeTable
observe_onTable
on_error_resume_nextTable
publish_subject callbacksTable
publish_subject routinesTable
repeatTable
scanTable
single-threaded locksTable
skipTable
switch_on_nextTable
takeTable
take_lastTable
take_untilTable
timeoutTable
trampoline schedulerTable
windowTable
with_latest_fromTable
ci-windowsObservable constructionTable
Observable liftTable
Observable subscribeTable
Observable subscribe #2Table
Observer constructionTable
OnNextTable
Subscriber constructionTable
SubscriptionTable
bufferTable
chains creation testTable
combine_latestTable
concatTable
distinct_until_changedTable
firstTable
foundamental sourcesTable
fromTable
immediate schedulerTable
justTable
lastTable
mapTable
mergeTable
observe_onTable
on_error_resume_nextTable
publish_subject callbacksTable
publish_subject routinesTable
repeatTable
scanTable
single-threaded locksTable
skipTable
switch_on_nextTable
takeTable
take_lastTable
take_untilTable
timeoutTable
trampoline schedulerTable
windowTable
with_latest_fromTable
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/2)
template<constraint::decayed_type CastBeforeDivide, constraint::observable TObs> | ||
auto average_impl(TObs&& observable); | ||
|
||
template<constraint::observable TObs> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no type named observable
in namespace rpp::constraint
auto average_impl(TObs&& observable); | ||
|
||
template<constraint::observable TObs> | ||
auto sum_impl(TObs&& observable); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use of undeclared identifier observable
template<constraint::observable TObs> | ||
auto sum_impl(TObs&& observable); | ||
|
||
template<constraint::observable TObs> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no type named observable
in namespace rpp::constraint
auto sum_impl(TObs&& observable); | ||
|
||
template<constraint::observable TObs> | ||
auto count_impl(TObs&& observable); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use of undeclared identifier observable
template<constraint::observable TObs> | ||
auto count_impl(TObs&& observable); | ||
|
||
template<constraint::observable TObs, typename Comparator> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no type named observable
in namespace rpp::constraint
auto count_impl(TObs&& observable); | ||
|
||
template<constraint::observable TObs, typename Comparator> | ||
auto min_impl(TObs&& observable, Comparator&& comparator); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use of undeclared identifier observable
auto count_impl(TObs&& observable); | ||
|
||
template<constraint::observable TObs, typename Comparator> | ||
auto min_impl(TObs&& observable, Comparator&& comparator); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comparator
does not refer to a value
auto count_impl(TObs&& observable); | ||
|
||
template<constraint::observable TObs, typename Comparator> | ||
auto min_impl(TObs&& observable, Comparator&& comparator); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use of undeclared identifier comparator
; did you mean operator
?
auto min_impl(TObs&& observable, Comparator&& comparator); | |
auto min_impl(TObs&& observable, Comparator&& operator); |
template<constraint::observable TObs, typename Comparator> | ||
auto min_impl(TObs&& observable, Comparator&& comparator); | ||
|
||
template<constraint::observable TObs, typename Comparator> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no type named observable
in namespace rpp::constraint
auto min_impl(TObs&& observable, Comparator&& comparator); | ||
|
||
template<constraint::observable TObs, typename Comparator> | ||
auto max_impl(TObs&& observable, Comparator&& comparator); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use of undeclared identifier observable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (2/2)
auto min_impl(TObs&& observable, Comparator&& comparator); | ||
|
||
template<constraint::observable TObs, typename Comparator> | ||
auto max_impl(TObs&& observable, Comparator&& comparator); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comparator
does not refer to a value
auto min_impl(TObs&& observable, Comparator&& comparator); | ||
|
||
template<constraint::observable TObs, typename Comparator> | ||
auto max_impl(TObs&& observable, Comparator&& comparator); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use of undeclared identifier comparator
; did you mean operator
?
auto max_impl(TObs&& observable, Comparator&& comparator); | |
auto max_impl(TObs&& observable, Comparator&& operator); |
Kudos, SonarCloud Quality Gate passed! |
#307