Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frank/tank gauges alignment #363

Merged
merged 10 commits into from
Feb 28, 2024
Merged

Frank/tank gauges alignment #363

merged 10 commits into from
Feb 28, 2024

Conversation

fwaalkens
Copy link
Contributor

@fwaalkens fwaalkens commented Feb 26, 2024 •
edited
Loading

Fixed multiple issues regarding the tanks UI.

  • Horizontal view flickering
  • Alignment on smaller views
  • Added translations for tank overview
  • Minor semantic fixes

image

image

image

@fwaalkens fwaalkens marked this pull request as ready for review February 26, 2024 13:05
@fwaalkens fwaalkens self-assigned this Feb 26, 2024
@fwaalkens fwaalkens added the bug Something isn't working label Feb 26, 2024
@martinbosma martinbosma force-pushed the frank/tank-gauges-alignment branch from 6606b3a to 9c09958 Compare February 26, 2024 13:23
@martinbosma martinbosma marked this pull request as draft February 26, 2024 13:24
@martinbosma martinbosma force-pushed the frank/tank-gauges-alignment branch from 9c09958 to 7c3c218 Compare February 26, 2024 13:30
@martinbosma
Copy link
Contributor

In below screenshots there appears to be enough width, yet the tank name is truncated to only a few characters. Can we improve this? Make the gauge less wide and add more room for the name?

Simulation: ./run.sh -s s

1800x900:
Screen Shot 2024-02-26 at 14 39 45

1500x500:
Screen Shot 2024-02-26 at 14 44 59

800x900, Text gets truncated, while there is still space:
Screen Shot 2024-02-26 at 14 42 47

@martinbosma martinbosma added this to the v3.30 milestone Feb 26, 2024
@martinbosma
Copy link
Contributor

Much better, although sometimes the text still get truncated while there is enough space.

1800x900:
Screen Shot 2024-02-26 at 16 54 27

@martinbosma martinbosma force-pushed the frank/tank-gauges-alignment branch from df908f2 to a884945 Compare February 28, 2024 10:39
@fwaalkens
Copy link
Contributor Author

Tested on multiple mfd's:

image
image
image
image

@martinbosma martinbosma force-pushed the frank/tank-gauges-alignment branch from f3281fe to 36dcfcd Compare February 28, 2024 14:32
martinbosma
martinbosma approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@martinbosma martinbosma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martinbosma martinbosma marked this pull request as ready for review February 28, 2024 14:37
@fwaalkens fwaalkens merged commit 53872db into master Feb 28, 2024
1 check passed
@martinbosma martinbosma deleted the frank/tank-gauges-alignment branch February 28, 2024 14:38
@fwaalkens fwaalkens mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinbosma martinbosma martinbosma approved these changes

Assignees

@fwaalkens fwaalkens

Labels
bug Something isn't working
Projects
None yet
Milestone
v3.30
Development

Successfully merging this pull request may close these issues.
2 participants
@fwaalkens @martinbosma