Close media key sessions and clear media keys when media detached #2664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Close media key sessions and clear media keys when media detached.
Why is this Pull Request needed?
When we tested Hls.js on Android Webview on FireTV, we found that the player failed to play DRM titles after finishing 5 or 6 titles. After investigation, the root cause is:
Related adb logs:
So we borrow Google Shaka player's idea, do these necessary cleanups when media is detached.
Are there any points in the code the reviewer needs to double check?
There is one point need further discussion: forwe decide to not add this event for now, will review the DRM API proposal and discuss how to handle itrecoverMediaError
method inHls
class, we need to wait until all cleanups are finished beforeattachMedia
again: https://github.com/video-dev/hls.js/blob/master/src/hls.ts#L332. I would suggest we use a new eventEME_DESTROYED
to make it workResolves issues:
N/A
Checklist