Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: PIPELINE_DECODE_ERROR when switching from Clear to DRM content #4236

Conversation

hongfeih-es
Copy link
Contributor

This PR will...

Fix PIPELINE_DECODE_ERROR when switching from clear content to DRM content.

Why is this Pull Request needed?

When play DRM streams start with clear contents, player will report error like

The video playback was aborted due to a corruption problem or because the video used features your browser did not support - PIPELINE_ERROR_DECODE: audio decoder reinitialization failed

setMediaKeys need to be called before encrypted segments push to buffer

Are there any points in the code the reviewer needs to double check?

No

Resolves issues:

#4230

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch
Copy link
Collaborator

This should be handled by #4930. If you're still seeing the issue and mediaKeys are not reset on key change, could you share a stream sample that reproduces the issue?

@robwalch robwalch added the DRM label Sep 28, 2022
@robwalch robwalch mentioned this pull request Oct 21, 2022
3 tasks
@robwalch robwalch closed this Dec 21, 2022
@hongfeih-es hongfeih-es deleted the bugfix/Transition-from-Clear-to-DRM-content branch April 26, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants