Fallback to inline demuxing on Worker error #5016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fallback to demuxing on the main runtime look when an error event is received from the Worker.
Why is this Pull Request needed?
Worker errors can occur as a result of webworkify JS injection issues like #5015 or other runtime issues. Disabling the worker to continue streaming playback is better that emitting a fatal error.
We already have a try-catch block to fallback in case the worker could not be instantiated, so why not fallback in the case of an exception.
Resolves issues:
Helps with builds that break webworkify like #5015
Checklist