Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve webworkify handling of named functions where name is in quotes #5036

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Improve webworkify handling of named functions where name is in quotes #5036

merged 1 commit into from
Nov 15, 2022

Conversation

robwalch
Copy link
Collaborator

This PR will...

Handle a case that breaks worker js injection where rebundled module js is formatted:

"function.name"(_) {

}

Resolves issues:

#5015

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.2.8 milestone Nov 15, 2022
@robwalch robwalch merged commit 6f76930 into master Nov 15, 2022
@robwalch robwalch deleted the bugfix/webworkify-webpack5-min branch November 15, 2022 16:45
robwalch added a commit that referenced this pull request Nov 15, 2022
@robwalch
Improve webworkify handling of named functions where name is in quotes (
75ba25e 
#5036)
@robwalch robwalch mentioned this pull request Nov 15, 2022
Closed
5 tasks
@robwalch robwalch requested a review from itsjamie November 15, 2022 19:08
@robwalch robwalch mentioned this pull request Dec 17, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsjamie itsjamie Awaiting requested review from itsjamie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.8
Development

Successfully merging this pull request may close these issues.
1 participant
@robwalch