Error on unsupported media #5175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Error when media probing fails, as well as when probing segments fails three times in a row.
Why is this Pull Request needed?
HLS.js should error on bad or unsupported streams after 1-3 failed segment parsing attempts.
Are there any points in the code the reviewer needs to double check?
HLS.js would ignore any number of empty segments prior to this change, potentially loading an entire playlist of media with no samples. Now, only three consecutive failures will be allowed.
Any probe attempt that fails will fail immediately. This change could be removed, in favor of falling back to the empty error that still advances through the playlist up to three times.
Resolves issues:
Fixes #5011
Checklist